separate tracing environment variables #6323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
May 25, 2021
magik6k
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this PR is to make it easier to setup metrics in kubernetes environments.
in kubernetes, the IP address of the agent is not known until the pod starts, after which it can be made available as an environment variable. By that time, it is too late to append the port number. When the agent endpoint is read in with a single environment variable, the best you can do is combine the host and port numbers as a bash script prior to starting lotus.
With this PR, the agent host and port can be read in with two environment variables without any bash shenanigans.
Also, I added environment variables to support jaeger authentication, or sending directly to the collector.